Fix memory leaks in audit & VirtualBox code

* src/util/virtaudit.c: Free audit string
* src/vbox/vbox_XPCOMCGlue.c: Free library name
This commit is contained in:
Daniel P. Berrange 2010-11-24 11:49:40 +00:00
parent 6b3ede3f02
commit 6aff3f2091
2 changed files with 6 additions and 1 deletions

View File

@ -32,6 +32,7 @@
#include "virtaudit.h"
#include "util.h"
#include "files.h"
#include "memory.h"
/* Provide the macros in case the header file is old.
FIXME: should be removed. */
@ -110,8 +111,10 @@ void virAuditSend(const char *file ATTRIBUTE_UNUSED, const char *func,
}
#if HAVE_AUDIT
if (auditfd < 0)
if (auditfd < 0) {
VIR_FREE(str);
return;
}
if (str) {
static const int record_types[] = {
@ -128,6 +131,7 @@ void virAuditSend(const char *file ATTRIBUTE_UNUSED, const char *func,
VIR_WARN("Failed to send audit message %s: %s",
NULLSTR(str), virStrerror(errno, ebuf, sizeof ebuf));
}
VIR_FREE(str);
}
#endif
}

View File

@ -98,6 +98,7 @@ static int tryLoadOne(const char *dir, bool setAppHome, bool ignoreMissing)
VIR_ERROR(_("Libaray '%s' doesn't exist"), name);
}
VIR_FREE(name);
return -1;
}
} else {