From 6b00f4f41c88bb5c9b46a7d5603d8fa947b89410 Mon Sep 17 00:00:00 2001 From: Wang Yechao Date: Fri, 9 Nov 2018 14:41:23 +0800 Subject: [PATCH] qemu: Fix segfault in qemuDomainPrimeVirtioDeviceAddresses On aarch64, lauch vm with the follow configuration:
libvirtd will crash when accessing net->model. Signed-off-by: Wang Yechao Reviewed-by: Andrea Bolognani --- src/qemu/qemu_domain_address.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 24dd7c1a58..27c9bfb946 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -324,7 +324,8 @@ qemuDomainPrimeVirtioDeviceAddresses(virDomainDefPtr def, for (i = 0; i < def->nnets; i++) { virDomainNetDefPtr net = def->nets[i]; - if (STREQ(net->model, "virtio") && + if (net->model && + STREQ(net->model, "virtio") && net->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { net->info.type = type; }