External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 14:15:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: Rework virDomainEmulatorPinDefParseXML

Browse Source 
In preparation for using auto free mechanism, change to using the
VIR_STEAL_PTR on @def to @ret and of course be sure to properly clean
up @def in cleanup.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
John Ferlan 2019-02-20 11:07:07 -05:00
parent b6aacfc435
commit 6c2e8566f8
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/conf/domain_conf.c
View File

@ -18397,6 +18397,7 @@ static virBitmapPtr
virDomainEmulatorPinDefParseXML(xmlNodePtr node) virDomainEmulatorPinDefParseXML(xmlNodePtr node)
{ {
virBitmapPtr def = NULL; virBitmapPtr def = NULL;
virBitmapPtr ret = NULL;
char *tmp = NULL; char *tmp = NULL;
if (!(tmp = virXMLPropString(node, "cpuset"))) { if (!(tmp = virXMLPropString(node, "cpuset"))) {
@ -18411,14 +18412,15 @@ virDomainEmulatorPinDefParseXML(xmlNodePtr node)
if (virBitmapIsAllClear(def)) { if (virBitmapIsAllClear(def)) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("Invalid value of 'cpuset': %s"), tmp); _("Invalid value of 'cpuset': %s"), tmp);
virBitmapFree(def);
def = NULL;
goto cleanup; goto cleanup;
} }
VIR_STEAL_PTR(ret, def);
cleanup: cleanup:
virBitmapFree(def);
VIR_FREE(tmp); VIR_FREE(tmp);
return def; return ret;
} }