External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-08-04 16:03:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

libxl: don't overwrite error from virNetSocketNewConnectTCP()

Browse Source 
Remove redundant error reporting in libxlDomainMigrationPerform().
virNetSocketNewConnectTCP() is perfectly capable of reporting
sensible errors.
This commit is contained in:
Jim Fehlig 2015-09-03 10:14:20 -06:00
parent e92e5ba128
commit 6ce939c247
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/libxl/libxl_migration.c
View File

@ -472,7 +472,6 @@ libxlDomainMigrationPerform(libxlDriverPrivatePtr driver,
virURIPtr uri = NULL; virURIPtr uri = NULL;
virNetSocketPtr sock; virNetSocketPtr sock;
int sockfd = -1; int sockfd = -1;
int saved_errno = EINVAL;
int ret = -1; int ret = -1;
/* parse dst host:port from uri */ /* parse dst host:port from uri */
@ -487,12 +486,8 @@ libxlDomainMigrationPerform(libxlDriverPrivatePtr driver,
/* socket connect to dst host:port */ /* socket connect to dst host:port */
if (virNetSocketNewConnectTCP(hostname, portstr, if (virNetSocketNewConnectTCP(hostname, portstr,
AF_UNSPEC, AF_UNSPEC,
&sock) < 0) { &sock) < 0)
virReportSystemError(saved_errno,
_("unable to connect to '%s:%s'"),
hostname, portstr);
goto cleanup; goto cleanup;
}
if (virNetSocketSetBlocking(sock, true) < 0) { if (virNetSocketSetBlocking(sock, true) < 0) {
virObjectUnref(sock); virObjectUnref(sock);