From 6d670a1fc151e6c9ba2a6b9be2cb8d1e0647b90c Mon Sep 17 00:00:00 2001 From: Daniel Veillard Date: Wed, 8 Oct 2008 13:44:40 +0000 Subject: [PATCH] use safewrite() and plug a leak * src/cgroup.c: use safewrite() * src/qemu_driver.c: missing VIR_FREE pojnted out by Eduardo Habkost Daniel --- ChangeLog | 5 +++++ src/cgroup.c | 2 +- src/qemu_driver.c | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 2b2eab66e5..5b1240068c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Wed Oct 8 15:42:44 CEST 2008 Daniel Veillard + + * src/cgroup.c: use safewrite() + * src/qemu_driver.c: missing VIR_FREE pojnted out by Eduardo Habkost + Tue Oct 7 23:08:51 CEST 2008 Jim Meyering avoid "make syntax-check" failure diff --git a/src/cgroup.c b/src/cgroup.c index ed206dc643..f1801c89ce 100644 --- a/src/cgroup.c +++ b/src/cgroup.c @@ -649,7 +649,7 @@ int virCgroupAddTask(virCgroupPtr group, pid_t pid) goto done; } - if (safe_write(fd, pidstr, strlen(pidstr)) <= 0) { + if (safewrite(fd, pidstr, strlen(pidstr)) <= 0) { rc = -errno; goto done; } diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 806608d782..a88cb75618 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -2176,6 +2176,7 @@ static int qemudDomainShutdown(virDomainPtr dom) { "%s", _("shutdown operation failed")); return -1; } + VIR_FREE(info); return 0; }