External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-26 23:55:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: Append 'resctrl' object according to number of monitor group directly

Browse Source 
'virResctrlAllocIsEmpty' checks if cache allocation or memory
bandwidth allocation settings are specified in configuration
file. It is not proper to be used in checking memory bandwidth
allocation is specified in XML settings because this function
could not distinguish memory bandwidth allocations from cache
allocations.

Here using the local variable @n, which indicates the cache
allocation groups or memory bandwidth groups depending on the
context it is in, to decide if append a new @resctrl object.

If @n is zero and no monitors groups specified in XML, then
we should not append a new @resctrl object to @def->resctrls.

This kind of replacement is also more efficient and avoiding
a long function calling path.

Signed-off-by: Wang Huaqiang <huaqiang.wang@intel.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Wang Huaqiang 2019-06-11 11:31:11 +08:00 committed by Michal Privoznik
parent df471f4188
commit 6d7d79856c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/conf/domain_conf.c
View File

@ -19412,7 +19412,7 @@ virDomainCachetuneDefParse(virDomainDefPtr def,
/* If no <cache> element or <monitor> element in <cachetune>, do not
* append any resctrl element */
if (!resctrl->nmonitors && virResctrlAllocIsEmpty(alloc)) {
if (!resctrl->nmonitors && n == 0) {
ret = 0;
goto cleanup;
}
@ -19601,7 +19601,7 @@ virDomainMemorytuneDefParse(virDomainDefPtr def,
return -1;
}
if (virResctrlAllocIsEmpty(alloc))
if (n == 0)
return 0;
/*