diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in index edbb948215..52e44637f2 100644 --- a/docs/formatdomaincaps.html.in +++ b/docs/formatdomaincaps.html.in @@ -175,7 +175,7 @@ floppy, or lun.

Hard drives, floppy disks, CDROMs

-

Disk capabilities are exposed under disk element. For +

Disk capabilities are exposed under the disk element. For instance:

@@ -216,6 +216,34 @@
       element for a <disk/>.
     
 
+
+    

Graphical framebuffers

+

Graphics device capabilities are exposed under the + graphics element. For instance:

+ +
+<domainCapabilities>
+  ...
+  <devices>
+    <graphics supported='yes'>
+      <enum name='type'>
+        <value>sdl</value>
+        <value>vnc</value>
+        <value>spice</value>
+      </enum>
+    </graphics>
+    ...
+  </devices>
+</domainCapabilities>
+
+ +
+
type
+
Options for the type attribute of the <graphics/> + element.
+
+ +

Host device assignment

Some host devices can be passed through to a guest (e.g. USB, PCI and SCSI). Well, only if the following is enabled:

diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng index 0d2777b56e..3e82b5771a 100644 --- a/docs/schemas/domaincaps.rng +++ b/docs/schemas/domaincaps.rng @@ -72,6 +72,7 @@ + @@ -84,6 +85,13 @@ + + + + + + + diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index eb880ae389..232acd5fe3 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -246,6 +246,18 @@ virDomainCapsDeviceDiskFormat(virBufferPtr buf, } +static void +virDomainCapsDeviceGraphicsFormat(virBufferPtr buf, + virDomainCapsDeviceGraphicsPtr const graphics) +{ + FORMAT_PROLOGUE(graphics); + + ENUM_PROCESS(graphics, type, virDomainGraphicsTypeToString); + + FORMAT_EPILOGUE(graphics); +} + + static void virDomainCapsDeviceHostdevFormat(virBufferPtr buf, virDomainCapsDeviceHostdevPtr const hostdev) @@ -314,6 +326,7 @@ virDomainCapsFormatInternal(virBufferPtr buf, virBufferAdjustIndent(buf, 2); virDomainCapsDeviceDiskFormat(buf, &caps->disk); + virDomainCapsDeviceGraphicsFormat(buf, &caps->graphics); virDomainCapsDeviceHostdevFormat(buf, &caps->hostdev); virBufferAdjustIndent(buf, -2); diff --git a/src/conf/domain_capabilities.h b/src/conf/domain_capabilities.h index 95afe5e834..545ada762c 100644 --- a/src/conf/domain_capabilities.h +++ b/src/conf/domain_capabilities.h @@ -69,6 +69,13 @@ struct _virDomainCapsDeviceDisk { /* add new fields here */ }; +typedef struct _virDomainCapsDeviceGraphics virDomainCapsDeviceGraphics; +typedef virDomainCapsDeviceGraphics *virDomainCapsDeviceGraphicsPtr; +struct _virDomainCapsDeviceGraphics { + bool supported; + virDomainCapsEnum type; /* virDomainGraphicsType */ +}; + typedef struct _virDomainCapsDeviceHostdev virDomainCapsDeviceHostdev; typedef virDomainCapsDeviceHostdev *virDomainCapsDeviceHostdevPtr; struct _virDomainCapsDeviceHostdev { @@ -101,6 +108,7 @@ struct _virDomainCaps { virDomainCapsOS os; virDomainCapsDeviceDisk disk; + virDomainCapsDeviceGraphics graphics; virDomainCapsDeviceHostdev hostdev; /* add new domain devices here */ diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 30dc33a5d3..c675f9f498 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -4170,6 +4170,23 @@ virQEMUCapsFillDomainDeviceDiskCaps(virQEMUCapsPtr qemuCaps, } +static int +virQEMUCapsFillDomainDeviceGraphicsCaps(virQEMUCapsPtr qemuCaps, + virDomainCapsDeviceGraphicsPtr dev) +{ + dev->supported = true; + + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_SDL)) + VIR_DOMAIN_CAPS_ENUM_SET(dev->type, VIR_DOMAIN_GRAPHICS_TYPE_SDL); + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_VNC)) + VIR_DOMAIN_CAPS_ENUM_SET(dev->type, VIR_DOMAIN_GRAPHICS_TYPE_VNC); + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_SPICE)) + VIR_DOMAIN_CAPS_ENUM_SET(dev->type, VIR_DOMAIN_GRAPHICS_TYPE_SPICE); + + return 0; +} + + static int virQEMUCapsFillDomainDeviceHostdevCaps(virQEMUCapsPtr qemuCaps, virDomainCapsDeviceHostdevPtr hostdev) @@ -4281,13 +4298,16 @@ virQEMUCapsFillDomainCaps(virDomainCapsPtr domCaps, virDomainCapsOSPtr os = &domCaps->os; virDomainCapsDeviceDiskPtr disk = &domCaps->disk; virDomainCapsDeviceHostdevPtr hostdev = &domCaps->hostdev; + virDomainCapsDeviceGraphicsPtr graphics = &domCaps->graphics; int maxvcpus = virQEMUCapsGetMachineMaxCpus(qemuCaps, domCaps->machine); domCaps->maxvcpus = maxvcpus; if (virQEMUCapsFillDomainOSCaps(qemuCaps, os, loader, nloader) < 0 || - virQEMUCapsFillDomainDeviceDiskCaps(qemuCaps, domCaps->machine, disk) < 0 || + virQEMUCapsFillDomainDeviceDiskCaps(qemuCaps, + domCaps->machine, disk) < 0 || + virQEMUCapsFillDomainDeviceGraphicsCaps(qemuCaps, graphics) < 0 || virQEMUCapsFillDomainDeviceHostdevCaps(qemuCaps, hostdev) < 0 || virQEMUCapsFillDomainFeatureGICCaps(qemuCaps, domCaps) < 0) return -1; diff --git a/tests/domaincapsschemadata/domaincaps-basic.xml b/tests/domaincapsschemadata/domaincaps-basic.xml index 6587d56a70..f0f08642cd 100644 --- a/tests/domaincapsschemadata/domaincaps-basic.xml +++ b/tests/domaincapsschemadata/domaincaps-basic.xml @@ -6,6 +6,7 @@ + diff --git a/tests/domaincapsschemadata/domaincaps-full.xml b/tests/domaincapsschemadata/domaincaps-full.xml index d4f91fa600..b3b8855a7f 100644 --- a/tests/domaincapsschemadata/domaincaps-full.xml +++ b/tests/domaincapsschemadata/domaincaps-full.xml @@ -39,6 +39,15 @@ sd + + + sdl + vnc + rdp + desktop + spice + + subsystem diff --git a/tests/domaincapsschemadata/domaincaps-qemu_1.6.50-1.xml b/tests/domaincapsschemadata/domaincaps-qemu_1.6.50-1.xml index 1e73ff11c0..147424d674 100644 --- a/tests/domaincapsschemadata/domaincaps-qemu_1.6.50-1.xml +++ b/tests/domaincapsschemadata/domaincaps-qemu_1.6.50-1.xml @@ -34,6 +34,13 @@ usb + + + sdl + vnc + spice + + subsystem diff --git a/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-1.xml b/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-1.xml index 244700a1e1..f8f7465f53 100644 --- a/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-1.xml +++ b/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-1.xml @@ -34,6 +34,13 @@ usb + + + sdl + vnc + spice + + subsystem diff --git a/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-2.xml b/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-2.xml index 411c6b7a0b..7913703288 100644 --- a/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-2.xml +++ b/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-2.xml @@ -34,6 +34,12 @@ usb + + + sdl + vnc + + subsystem diff --git a/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-3.xml b/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-3.xml index 21c59a89f5..6f30819dfe 100644 --- a/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-3.xml +++ b/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-3.xml @@ -34,6 +34,12 @@ usb + + + sdl + vnc + + subsystem diff --git a/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-4.xml b/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-4.xml index c972d5eea4..6845e92e3a 100644 --- a/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-4.xml +++ b/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-4.xml @@ -34,6 +34,12 @@ usb + + + sdl + vnc + + subsystem diff --git a/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-5.xml b/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-5.xml index e4b8c3a0b9..68d88d1fc9 100644 --- a/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-5.xml +++ b/tests/domaincapsschemadata/domaincaps-qemu_2.6.0-5.xml @@ -32,6 +32,12 @@ usb + + + sdl + vnc + + subsystem diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index ee78555363..6bef6823cd 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -61,6 +61,7 @@ fillAllCaps(virDomainCapsPtr domCaps) virDomainCapsOSPtr os = &domCaps->os; virDomainCapsLoaderPtr loader = &os->loader; virDomainCapsDeviceDiskPtr disk = &domCaps->disk; + virDomainCapsDeviceGraphicsPtr graphics = &domCaps->graphics; virDomainCapsDeviceHostdevPtr hostdev = &domCaps->hostdev; domCaps->maxvcpus = 255; @@ -79,6 +80,9 @@ fillAllCaps(virDomainCapsPtr domCaps) SET_ALL_BITS(disk->diskDevice); SET_ALL_BITS(disk->bus); + graphics->supported = true; + SET_ALL_BITS(graphics->type); + hostdev->supported = true; SET_ALL_BITS(hostdev->mode); SET_ALL_BITS(hostdev->startupPolicy);