mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 22:25:25 +00:00
util: Resolve memory leaks in virLogParse{Output|Filter}
In both virLogParseOutput and virLogParseFilter, rather than returning NULL, goto cleanup since it's possible that for each the first condition passes, but the || condition doesn't and thus we leak memory.
This commit is contained in:
parent
95e66fcedf
commit
6de78c63a4
@ -1466,7 +1466,7 @@ virLogParseOutput(const char *src)
|
||||
if (!(tokens = virStringSplitCount(src, ":", 0, &count)) || count < 2) {
|
||||
virReportError(VIR_ERR_INVALID_ARG,
|
||||
_("Malformed format for output '%s'"), src);
|
||||
return NULL;
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
if (virStrToLong_uip(tokens[0], NULL, 10, &prio) < 0 ||
|
||||
@ -1575,7 +1575,7 @@ virLogParseFilter(const char *src)
|
||||
if (!(tokens = virStringSplitCount(src, ":", 0, &count)) || count != 2) {
|
||||
virReportError(VIR_ERR_INVALID_ARG,
|
||||
_("Malformed format for filter '%s'"), src);
|
||||
return NULL;
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
if (virStrToLong_uip(tokens[0], NULL, 10, &prio) < 0 ||
|
||||
|
Loading…
Reference in New Issue
Block a user