From 6e07f72ee53738d8a91784bd3df633e9b51e7a6c Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Mon, 4 Jul 2011 10:22:50 +0800 Subject: [PATCH] rpc: avoid memory leak on error Detected by Coverity. The leak is on an error path, but I'm not sure whether that path is likely to be triggered in practice. * src/rpc/virnetserverservice.c (virNetServerServiceAccept): Plug leak. --- src/rpc/virnetserverservice.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/rpc/virnetserverservice.c b/src/rpc/virnetserverservice.c index e84f72c918..8c250e246d 100644 --- a/src/rpc/virnetserverservice.c +++ b/src/rpc/virnetserverservice.c @@ -82,7 +82,12 @@ cleanup: return; error: - virNetSocketFree(clientsock); + if (client) { + virNetServerClientClose(client); + virNetServerClientFree(client); + } else { + virNetSocketFree(clientsock); + } }