External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

rpc: Add typedef for the anonymous enum used for authentication methods

Browse Source 
Add typedef for the anonymous enum used for the authentication methods
and remove the default case. This allows the usage of the type in a
switch statement and taking advantage of the compilers feature to
detect uncovered cases.

Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
Reviewed-by: Stefan Zimmermann <stzi@linux.vnet.ibm.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
Marc Hartmayer 2017-12-21 15:28:59 +01:00 committed by John Ferlan
parent ed88b37fb4
commit 6e7e553180
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
daemon/remote.c
View File

@ -3279,7 +3279,7 @@ remoteDispatchAuthList(virNetServerPtr server,
if (VIR_ALLOC_N(ret->types.types_val, ret->types.types_len) < 0) if (VIR_ALLOC_N(ret->types.types_val, ret->types.types_len) < 0)
goto cleanup; goto cleanup;
switch (auth) { switch ((virNetServerServiceAuthMethods) auth) {
case VIR_NET_SERVER_SERVICE_AUTH_NONE: case VIR_NET_SERVER_SERVICE_AUTH_NONE:
ret->types.types_val[0] = REMOTE_AUTH_NONE; ret->types.types_val[0] = REMOTE_AUTH_NONE;
break; break;
@ -3289,8 +3289,6 @@ remoteDispatchAuthList(virNetServerPtr server,
case VIR_NET_SERVER_SERVICE_AUTH_SASL: case VIR_NET_SERVER_SERVICE_AUTH_SASL:
ret->types.types_val[0] = REMOTE_AUTH_SASL; ret->types.types_val[0] = REMOTE_AUTH_SASL;
break; break;
default:
ret->types.types_val[0] = REMOTE_AUTH_NONE;
} }
rv = 0; rv = 0;

4
src/rpc/virnetserverservice.h
View File

@ -27,11 +27,11 @@
# include "virnetserverprogram.h" # include "virnetserverprogram.h"
# include "virobject.h" # include "virobject.h"
enum { typedef enum {
VIR_NET_SERVER_SERVICE_AUTH_NONE = 0, VIR_NET_SERVER_SERVICE_AUTH_NONE = 0,
VIR_NET_SERVER_SERVICE_AUTH_SASL, VIR_NET_SERVER_SERVICE_AUTH_SASL,
VIR_NET_SERVER_SERVICE_AUTH_POLKIT, VIR_NET_SERVER_SERVICE_AUTH_POLKIT,
}; } virNetServerServiceAuthMethods;
typedef int (*virNetServerServiceDispatchFunc)(virNetServerServicePtr svc, typedef int (*virNetServerServiceDispatchFunc)(virNetServerServicePtr svc,
virNetSocketPtr sock, virNetSocketPtr sock,