External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-24 22:55:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove checking of return value of virHashNew

Browse Source 
There are two calls to virHashNew which check the return value. It's not
necessary any more as virHashNew always returns a valid pointer.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2020-01-28 13:40:24 +01:00
parent 2a5ea0a0c1
commit 6eab924daa
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/conf/backup_conf.c
View File

@ -439,15 +439,11 @@ virDomainBackupAlignDisks(virDomainBackupDefPtr def,
virDomainDefPtr dom, virDomainDefPtr dom,
const char *suffix) const char *suffix)
{ {
g_autoptr(virHashTable) disks = NULL; g_autoptr(virHashTable) disks = virHashNew(NULL);
size_t i; size_t i;
int ndisks; int ndisks;
bool backup_all = false; bool backup_all = false;
if (!(disks = virHashNew(NULL)))
return -1;
/* Unlikely to have a guest without disks but technically possible. */ /* Unlikely to have a guest without disks but technically possible. */
if (!dom->ndisks) { if (!dom->ndisks) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",

3
src/qemu/qemu_monitor_json.c
View File

@ -2990,8 +2990,7 @@ qemuMonitorJSONBlockGetNamedNodeDataJSON(virJSONValuePtr nodes)
{ {
g_autoptr(virHashTable) ret = NULL; g_autoptr(virHashTable) ret = NULL;
if (!(ret = virHashNew((virHashDataFree) qemuMonitorJSONBlockNamedNodeDataFree))) ret = virHashNew((virHashDataFree) qemuMonitorJSONBlockNamedNodeDataFree);
return NULL;
if (virJSONValueArrayForeachSteal(nodes, if (virJSONValueArrayForeachSteal(nodes,
qemuMonitorJSONBlockGetNamedNodeDataWorker, qemuMonitorJSONBlockGetNamedNodeDataWorker,