External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-01 20:05:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuhotplugtest: Make the test more useful by validating used commands against QMP schema

Browse Source 
qemuhotplugtest validates only that a given command is used but not the
arguments of the command. With this patch we'll validate the arguments
against the QMP schema thus we can catch possible issues with deprecated
commands.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2023-03-09 18:07:45 +01:00
parent 706cd47487
commit 6eee2de99f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/qemuhotplugtest.c
View File

@ -57,6 +57,7 @@ struct qemuHotplugTestData {
GHashTable *capsLatestFiles;
GHashTable *capsCache;
GHashTable *schemaCache;
GHashTable *schema;
};
static int
@ -342,7 +343,7 @@ testQemuHotplug(const void *data)
if (qemuHotplugCreateObjects(driver.xmlopt, &vm, domain_xml,
test->arch, test->capsLatestFiles,
test->capsCache, test->schemaCache,
NULL) < 0)
&test->schema) < 0)
goto cleanup;
}
@ -356,7 +357,7 @@ testQemuHotplug(const void *data)
/* Now is the best time to feed the spoofed monitor with predefined
* replies. */
if (!(test_mon = qemuMonitorTestNew(driver.xmlopt, vm, NULL, NULL)))
if (!(test_mon = qemuMonitorTestNew(driver.xmlopt, vm, NULL, test->schema)))
goto cleanup;
tmp = test->mon;