External/libvirt
1
0
Fork 0
Code

vbox: Drop @data and @name from UIHost::CreateHostOnlyNetworkInterface()

Browse Source 
The @data and @name arguments of
UIHost::CreateHostOnlyNetworkInterface() callback are unused.
Drop them and also their propagation from parent functions.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Michal Privoznik 2023-01-22 13:01:41 +01:00
parent d983405ea2
commit 6f0ed13b52
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/vbox/vbox_network.c
View File

@ -429,8 +429,7 @@ vboxNetworkDefineCreateXML(virConnectPtr conn, const char *xml, bool start,
* NULL. (We can't assign a new name to hostonly network, only * NULL. (We can't assign a new name to hostonly network, only
* take the given name, say vboxnet0) * take the given name, say vboxnet0)
*/ */
gVBoxAPI.UIHost.CreateHostOnlyNetworkInterface(data, host, def->name, gVBoxAPI.UIHost.CreateHostOnlyNetworkInterface(host, &networkInterface);
&networkInterface);
if (!networkInterface) if (!networkInterface)
goto cleanup; goto cleanup;

3
src/vbox/vbox_tmpl.c
View File

@ -2004,8 +2004,7 @@ _hostFindHostNetworkInterfaceByName(IHost *host, PRUnichar *name,
} }
static nsresult static nsresult
_hostCreateHostOnlyNetworkInterface(struct _vboxDriver *data G_GNUC_UNUSED, _hostCreateHostOnlyNetworkInterface(IHost *host,
IHost *host, char *name G_GNUC_UNUSED,
IHostNetworkInterface **networkInterface) IHostNetworkInterface **networkInterface)
{ {
nsresult rc = -1; nsresult rc = -1;

3
src/vbox/vbox_uniformed_api.h
View File

@ -453,8 +453,7 @@ typedef struct {
IHostNetworkInterface **networkInterface); IHostNetworkInterface **networkInterface);
nsresult (*FindHostNetworkInterfaceByName)(IHost *host, PRUnichar *name, nsresult (*FindHostNetworkInterfaceByName)(IHost *host, PRUnichar *name,
IHostNetworkInterface **networkInterface); IHostNetworkInterface **networkInterface);
nsresult (*CreateHostOnlyNetworkInterface)(struct _vboxDriver *driver, nsresult (*CreateHostOnlyNetworkInterface)(IHost *host,
IHost *host, char *name,
IHostNetworkInterface **networkInterface); IHostNetworkInterface **networkInterface);
nsresult (*RemoveHostOnlyNetworkInterface)(IHost *host, vboxIID *iid, nsresult (*RemoveHostOnlyNetworkInterface)(IHost *host, vboxIID *iid,
IProgress **progress); IProgress **progress);