External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

qemu: Avoid the memory allocation and freeing

Browse Source
This commit is contained in:
Osier Yang 2012-04-11 22:40:34 +08:00
parent 8fb2164cff
commit 6fbd5737e9
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/qemu/qemu_process.c
View File

@ -1759,23 +1759,19 @@ static char *
qemuGetNumadAdvice(virDomainDefPtr def) qemuGetNumadAdvice(virDomainDefPtr def)
{ {
virCommandPtr cmd = NULL; virCommandPtr cmd = NULL;
char *args = NULL;
char *output = NULL; char *output = NULL;
if (virAsprintf(&args, "%d:%llu", def->vcpus, def->mem.cur_balloon) < 0) { cmd = virCommandNewArgList(NUMAD, "-w", NULL);
virReportOOMError(); virCommandAddArgFormat(cmd, "%d:%llu", def->vcpus,
goto out; def->mem.cur_balloon);
}
cmd = virCommandNewArgList(NUMAD, "-w", args, NULL);
virCommandSetOutputBuffer(cmd, &output); virCommandSetOutputBuffer(cmd, &output);
if (virCommandRun(cmd, NULL) < 0) if (virCommandRun(cmd, NULL) < 0)
qemuReportError(VIR_ERR_INTERNAL_ERROR, "%s", qemuReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("Failed to query numad for the advisory nodeset")); _("Failed to query numad for the "
"advisory nodeset"));
out:
VIR_FREE(args);
virCommandFree(cmd); virCommandFree(cmd);
return output; return output;
} }