External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-23 13:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Close all non-stdio FDs in virt-login-shell (CVE-2013-4400)

Browse Source 
We don't want to inherit any FDs in the new namespace
except for the stdio FDs. Explicitly close them all,
just in case some do not have the close-on-exec flag
set.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit b7fcc799ad5d8f3e55b89b94e599903e3c092467)
This commit is contained in:
Daniel P. Berrange 2013-10-09 15:14:34 +01:00
parent d8accf54e3
commit 6fc87e07a2
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/virt-login-shell.c
View File

@ -313,6 +313,18 @@ main(int argc, char **argv)
if (cpid == 0) {
pid_t ccpid;
int openmax = sysconf(_SC_OPEN_MAX);
int fd;
if (openmax < 0) {
virReportSystemError(errno, "%s",
_("sysconf(_SC_OPEN_MAX) failed"));
return EXIT_FAILURE;
}
for (fd = 3; fd < openmax; fd++) {
int tmpfd = fd;
VIR_MASS_CLOSE(tmpfd);
}
/* Fork once because we don't want to affect
* virt-login-shell's namespace itself
*/