External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: vircaps: Remove pointless testing of virCapabilitiesHostNUMAGetCpus

Browse Source 
The test case doesn't validate the returned map of cpus, just checks
that it didn't fail. We test the returned value indirectly via
qemuxml2argvtest.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2023-03-17 14:52:28 +01:00
parent 6ae5d71d38
commit 702620bd6b
1 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tests/vircapstest.c
View File

@ -22,34 +22,11 @@
#include "testutils.h"
#include "testutilslxc.h"
#include "capabilities.h"
#include "virbitmap.h"
#define VIR_FROM_THIS VIR_FROM_NONE
static int
test_virCapabilitiesGetCpusForNodemask(const void *data G_GNUC_UNUSED)
{
const char *nodestr = "3,4,5,6";
g_autoptr(virBitmap) nodemask = NULL;
g_autoptr(virBitmap) cpumap = NULL;
g_autoptr(virCapsHostNUMA) caps = NULL;
int mask_size = 8;
if (!(caps = virTestCapsBuildNUMATopology(3)))
return -1;
if (virBitmapParse(nodestr, &nodemask, mask_size) < 0)
return -1;
if (!(cpumap = virCapabilitiesHostNUMAGetCpus(caps, nodemask)))
return -1;
return 0;
}
static bool G_GNUC_UNUSED
doCapsCompare(virCaps *caps,
int ostype,
@ -141,9 +118,6 @@ mymain(void)
{
int ret = 0;
if (virTestRun("virCapabilitiesGetCpusForNodemask",
test_virCapabilitiesGetCpusForNodemask, NULL) < 0)
ret = -1;
#ifdef WITH_LXC
if (virTestRun("virCapsDomainDataLookupLXC",
test_virCapsDomainDataLookupLXC, NULL) < 0)