External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

vbox_temp: Resolve Coverity warnings

Browse Source 
Clean up code to resolve Coverity RESOURCE_LEAK's from commit id's
'632b9600' and 'b739f807'.
This commit is contained in:
John Ferlan 2014-06-11 09:14:50 -04:00
parent cc6484d486
commit 70bd552e67
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/vbox/vbox_tmpl.c
View File

@ -6267,6 +6267,11 @@ vboxSnapshotRedefine(virDomainPtr dom,
*/ */
parentUuid = virVBoxSnapshotConfHardDiskUuidByLocation(snapshotMachineDesc, parentUuid = virVBoxSnapshotConfHardDiskUuidByLocation(snapshotMachineDesc,
realReadOnlyDisksPath[it]); realReadOnlyDisksPath[it]);
if (parentUuid == NULL) {
VIR_FREE(readWriteDisk);
goto cleanup;
}
if (virVBoxSnapshotConfAddHardDiskToMediaRegistry(readWriteDisk, if (virVBoxSnapshotConfAddHardDiskToMediaRegistry(readWriteDisk,
snapshotMachineDesc->mediaRegistry, snapshotMachineDesc->mediaRegistry,
parentUuid) < 0) { parentUuid) < 0) {
@ -8576,14 +8581,17 @@ vboxDomainSnapshotDeleteMetadataOnly(virDomainSnapshotPtr snapshot)
virReportError(VIR_ERR_INTERNAL_ERROR, virReportError(VIR_ERR_INTERNAL_ERROR,
_("Unable to get medium uuid, rc=%08x"), _("Unable to get medium uuid, rc=%08x"),
(unsigned)rc); (unsigned)rc);
VIR_FREE(disk);
goto cleanup; goto cleanup;
} }
VBOX_UTF16_TO_UTF8(uuidUtf16, &uuid); VBOX_UTF16_TO_UTF8(uuidUtf16, &uuid);
disk->uuid = uuid; disk->uuid = uuid;
VBOX_UTF16_FREE(uuidUtf16); VBOX_UTF16_FREE(uuidUtf16);
if (VIR_STRDUP(disk->location, newLocationUtf8) < 0) if (VIR_STRDUP(disk->location, newLocationUtf8) < 0) {
VIR_FREE(disk);
goto cleanup; goto cleanup;
}
rc = newMedium->vtbl->GetFormat(newMedium, &formatUtf16); rc = newMedium->vtbl->GetFormat(newMedium, &formatUtf16);
VBOX_UTF16_TO_UTF8(formatUtf16, &format); VBOX_UTF16_TO_UTF8(formatUtf16, &format);