syntax-check: enforce the no-cvs-keywords prohibition

* Makefile.maint (sc_prohibit_cvs_keyword): New rule.
Suggested by Daniel Veillard.
The new test exposed two uses of $Date$.
* docs/Goals: Don't use $Date$.
* python/TODO: Likewise.

ChangeLog

@@ -1,3 +1,12 @@
+Fri Dec 12 18:50:20 +0100 2008 Jim Meyering <meyering@redhat.com>
+
+	syntax-check: enforce the no-cvs-keywords prohibition
+	* Makefile.maint (sc_prohibit_cvs_keyword): New rule.
+	Suggested by Daniel Veillard.
+	The new test exposed two uses of $\Date$.
+	* docs/Goals: Don't use $\Date$.
+	* python/TODO: Likewise.
+
 Fri Dec 12 17:08:08 +0100 2008 Jim Meyering <meyering@redhat.com>
 
 	avoid a spurious test failure on non-numa systems
@@ -11,7 +20,7 @@ Fri Dec 12 14:57:17 CET 2008 Daniel Veillard <veillard@redhat.com>
 
 Fri Dec 12 13:41:31 +0100 2008 Jim Meyering <meyering@redhat.com>
 
-	remove cvs $Id$ strings
+	remove cvs $\Id$ strings
 	* po/id.po: Likewise.
 	* qemud/remote_generate_stubs.pl: Likewise.
 	* src/virsh.c: Likewise.

Makefile.maint

@@ -81,6 +81,14 @@ sc_space_tab:
 	  { echo '$(ME): found SPACE-TAB sequence; remove the SPACE'	\
 		1>&2; exit 1; } || :
 
+cvs_keywords = \
+  Author|Date|Header|Id|Name|Locker|Log|RCSfile|Revision|Source|State
+
+sc_prohibit_cvs_keyword:
+	@grep -nE '\$$($(cvs_keywords))\$$' $$($(VC_LIST_EXCEPT)) &&	\
+	  { echo '$(ME): do not use CVS keyword expansion '		\
+		1>&2; exit 1; } || :
+
 # Don't use *scanf or the old ato* functions in `real' code.
 # They provide no error checking mechanism.
 # Instead, use strto* functions.

docs/Goals

@@ -26,4 +26,3 @@ the underlying acual implementation of the hypervisor calls.
    releases of the library.
 
 Daniel Veillard <veillard@redhat.com>
-$Date$

python/TODO

@@ -4,5 +4,3 @@
 - add examples, web page and python based test suite
 
 Daniel Veillard
-
-$Date$