External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-10 23:07:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

parallels: check and handle error for virAsprintf() calls

Browse Source 
Ignore the return in parallelsMakePoolName() since subsequent check
validates name was allocated.
This commit is contained in:
John Ferlan 2013-01-03 14:16:14 -05:00 committed by Eric Blake
parent 62cc7b702b
commit 718af45895
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/parallels/parallels_storage.c
View File

@ -146,7 +146,7 @@ static char *parallelsMakePoolName(virConnectPtr conn, const char *path)
if (i == 0)
name = strdup(path);
else
virAsprintf(&name, "%s-%u", path, i);
ignore_value(virAsprintf(&name, "%s-%u", path, i));
if (!name) {
virReportOOMError();
@ -310,8 +310,7 @@ static int parallelsAddDiskVolume(virStoragePoolObjPtr pool,
if (VIR_ALLOC(def))
goto no_memory;
virAsprintf(&def->name, "%s-%s", dom->def->name, diskName);
if (!def->name)
if (virAsprintf(&def->name, "%s-%s", dom->def->name, diskName) < 0)
goto no_memory;
def->type = VIR_STORAGE_VOL_FILE;