From 72423df9920491f8f59455a4161a7c31d1e15c8a Mon Sep 17 00:00:00 2001 From: Laine Stump Date: Wed, 18 Mar 2015 14:27:05 -0400 Subject: [PATCH] util: more verbose error when failing to create macvtap device Investigation of a problem with creating passthrough macvtap devices (https://bugzilla.redhat.com/show_bug.cgi?id=1185501) has shown that this slightly more verbose failure message is useful. In particular, the mac address can be used to determine the domain. You could also figure this out by looking at preceding messages in a debug log, but this gets it in a single place. --- src/util/virnetdevmacvlan.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index 72e1f65527..ec959a91c6 100644 --- a/src/util/virnetdevmacvlan.c +++ b/src/util/virnetdevmacvlan.c @@ -107,6 +107,7 @@ virNetDevMacVLanCreate(const char *ifname, unsigned int recvbuflen; struct nl_msg *nl_msg; struct nlattr *linkinfo, *info_data; + char macstr[VIR_MAC_STRING_BUFLEN]; if (virNetDevGetIndex(srcdev, &ifindex) < 0) return -1; @@ -177,8 +178,9 @@ virNetDevMacVLanCreate(const char *ifname, default: virReportSystemError(-err->error, - _("error creating %s type of interface attach to %s"), - type, srcdev); + _("error creating %s interface %s@%s (%s)"), + type, ifname, srcdev, + virMacAddrFormat(macaddress, macstr)); goto cleanup; } break;