External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-24 04:12:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix initialization of virCommandPtr when creating QEMU argv

Browse Source 
If the qemuBuildCommandLine method raised an error before the
virCommandPtr instance was created, the local var would not
be initialized, resulting in a possible SEGV in the error
cleanup branch. Also add some debugging of the method params
This commit is contained in:
Daniel P. Berrange 2012-09-14 15:35:33 +01:00
parent a55a610b30
commit 731c911ceb
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/qemu/qemu_command.c
View File

@ -4407,12 +4407,18 @@ qemuBuildCommandLine(virConnectPtr conn,
char *smp; char *smp;
int last_good_net = -1; int last_good_net = -1;
bool hasHwVirt = false; bool hasHwVirt = false;
virCommandPtr cmd; virCommandPtr cmd = NULL;
bool emitBootindex = false; bool emitBootindex = false;
int usbcontroller = 0; int usbcontroller = 0;
bool usblegacy = false; bool usblegacy = false;
uname_normalize(&ut); uname_normalize(&ut);
VIR_DEBUG("conn=%p driver=%p def=%p mon=%p json=%d "
"caps=%p migrateFrom=%s migrateFD=%d "
"snapshot=%p vmop=%d",
conn, driver, def, monitor_chr, monitor_json,
caps, migrateFrom, migrateFd, snapshot, vmop);
virUUIDFormat(def->uuid, uuid); virUUIDFormat(def->uuid, uuid);
emulator = def->emulator; emulator = def->emulator;