From 73bc9c163c806d662b7ced8555476f784ea22109 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Sun, 7 Dec 2008 20:45:28 +0000 Subject: [PATCH] Fix NULL crash & integer overflow --- ChangeLog | 4 ++++ src/test.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index ae77f058f7..c8c77fa51f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +Sun Dec 7 20:44:53 GMT 2008 Daniel P. Berrange + + * src/test.c: Fix integer long long overflow. Fix NULL defernce + Sun Dec 7 20:20:53 GMT 2008 Daniel P. Berrange * src/test.c: Remove bogus refresh call causing deadlock diff --git a/src/test.c b/src/test.c index a5b7c25cb0..257fc8a3cb 100644 --- a/src/test.c +++ b/src/test.c @@ -191,7 +191,7 @@ static const char *defaultPoolXML = " " ""; -static const unsigned long long defaultPoolCap = (100 * 1024 * 1024 * 1024ul); +static const unsigned long long defaultPoolCap = (100 * 1024 * 1024 * 1024ull); static const unsigned long long defaultPoolAlloc = 0; static int testStoragePoolObjSetDefaults(virStoragePoolObjPtr pool); @@ -2997,10 +2997,10 @@ testStorageVolumeCreateXML(virStoragePoolPtr pool, privpool->def->allocation); privpool->volumes.objs[privpool->volumes.count++] = privvol; - privvol = NULL; ret = virGetStorageVol(pool->conn, privpool->def->name, privvol->name, privvol->key); + privvol = NULL; cleanup: virStorageVolDefFree(privvol);