External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-29 00:55:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid crash when LXC start fails with no interface target

Browse Source 
If the <interface> device did not contain any <target>
element, LXC would crash on a NULL pointer if starting
the container failed

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit 68dceb635d)
This commit is contained in:
Daniel P. Berrange 2012-11-23 16:36:52 +00:00 committed by Cole Robinson
parent 49ed3cd1f6
commit 74aa3ffec2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/lxc/lxc_process.c
View File

@ -254,7 +254,8 @@ static void virLXCProcessCleanup(virLXCDriverPtr driver,
for (i = 0 ; i < vm->def->nnets ; i++) { for (i = 0 ; i < vm->def->nnets ; i++) {
virDomainNetDefPtr iface = vm->def->nets[i]; virDomainNetDefPtr iface = vm->def->nets[i];
vport = virDomainNetGetActualVirtPortProfile(iface); vport = virDomainNetGetActualVirtPortProfile(iface);
ignore_value(virNetDevSetOnline(iface->ifname, false)); if (iface->ifname)
ignore_value(virNetDevSetOnline(iface->ifname, false));
if (vport && vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH) if (vport && vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH)
ignore_value(virNetDevOpenvswitchRemovePort( ignore_value(virNetDevOpenvswitchRemovePort(
virDomainNetGetActualBridgeName(iface), virDomainNetGetActualBridgeName(iface),