External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuDomainDiskChangeSupported: Add missing iothreads check

Browse Source 
GSList of iothreads is not allowed to be changed while the
virtual machine is running.

Resolves: https://issues.redhat.com/browse/RHEL-23607
Signed-off-by: Adam Julis <ajulis@redhat.com>
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Adam Julis 2024-07-26 10:52:18 +02:00 committed by Peter Krempa
parent 5872ab7fe9
commit 74ef4888ff
1 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
src/qemu/qemu_domain.c
View File

@ -6591,6 +6591,49 @@ qemuDomainStorageSourceAccessAllow(virQEMUDriver *driver,
}
static bool
qemuDomainDiskChangeSupportedIothreads(virDomainDiskDef *disk,
virDomainDiskDef *orig_disk)
{
GSList *old = orig_disk->iothreads;
GSList *new = disk->iothreads;
while (true) {
virDomainDiskIothreadDef *old_def;
virDomainDiskIothreadDef *new_def;
size_t i;
/* match - both empty or both at the end */
if (!old && !new)
return true;
/* mismatched length of lists */
if (!old || !new)
goto fail;
old_def = old->data;
new_def = new->data;
if (old_def->id != new_def->id ||
old_def->nqueues != new_def->nqueues)
goto fail;
for (i = 0; i < old_def->nqueues; i++) {
if (old_def->queues[i] != new_def->queues[i])
goto fail;
}
new = new->next;
old = old->next;
}
fail:
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("cannot modify field '<iothreads>' (or it's parts) of the disk"));
return false;
}
/*
* Makes sure the @disk differs from @orig_disk only by the source
* path and nothing else. Fields that are being checked and the
@ -6735,6 +6778,9 @@ qemuDomainDiskChangeSupported(virDomainDiskDef *disk,
CHECK_EQ(discard, "discard", true);
CHECK_EQ(iothread, "iothread", true);
if (!qemuDomainDiskChangeSupportedIothreads(disk, orig_disk))
return false;
CHECK_STREQ_NULLABLE(domain_name,
"backenddomain");