From 759921d47ca81a05419d2d92c906b7365a133135 Mon Sep 17 00:00:00 2001
From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 20 Jul 2020 18:54:34 +0200
Subject: [PATCH] qemuDomainAttachDeviceMknodHelper: Don't leak data->target
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It's not really a problem since this is a helper process that
dies as soon as the helper function returns, but the cleanup code
will be replaced with a function soon and this change prepares
the code for that.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_namespace.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_namespace.c b/src/qemu/qemu_namespace.c
index 063e11bb6d..db38bc0e0d 100644
--- a/src/qemu/qemu_namespace.c
+++ b/src/qemu/qemu_namespace.c
@@ -1102,7 +1102,7 @@ struct qemuDomainAttachDeviceMknodData {
     virQEMUDriverPtr driver;
     virDomainObjPtr vm;
     const char *file;
-    const char *target;
+    char *target;
     GStatBuf sb;
     void *acl;
 #ifdef WITH_SELINUX
@@ -1248,6 +1248,7 @@ qemuDomainAttachDeviceMknodHelper(pid_t pid G_GNUC_UNUSED,
     freecon(data->tcon);
 # endif
     virFileFreeACLs(&data->acl);
+    VIR_FREE(data->target);
     return ret;
 }