External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

virStorageSourceIsSameLocation: Use switch statement for individual storage types

Browse Source 
Convert to a switch instead of a bunch of 'if (type == ...).

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Peter Krempa 2022-01-07 17:53:58 +01:00
parent 08406591ce
commit 75a7a3b597
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/conf/storage_source_conf.c
View File

@ -929,7 +929,8 @@ virStorageSourceIsSameLocation(virStorageSource *a,
STRNEQ_NULLABLE(a->snapshot, b->snapshot))
return false;
if (a->type == VIR_STORAGE_TYPE_NETWORK) {
switch (virStorageSourceGetActualType(a)) {
case VIR_STORAGE_TYPE_NETWORK:
if (a->protocol != b->protocol ||
a->nhosts != b->nhosts)
return false;
@ -941,11 +942,23 @@ virStorageSourceIsSameLocation(virStorageSource *a,
STRNEQ_NULLABLE(a->hosts[i].socket, b->hosts[i].socket))
return false;
}
}
break;
if (a->type == VIR_STORAGE_TYPE_NVME &&
!virStorageSourceNVMeDefIsEqual(a->nvme, b->nvme))
return false;
case VIR_STORAGE_TYPE_NVME:
if (!virStorageSourceNVMeDefIsEqual(a->nvme, b->nvme))
return false;
break;
case VIR_STORAGE_TYPE_VHOST_USER:
case VIR_STORAGE_TYPE_NONE:
case VIR_STORAGE_TYPE_FILE:
case VIR_STORAGE_TYPE_BLOCK:
case VIR_STORAGE_TYPE_DIR:
case VIR_STORAGE_TYPE_LAST:
case VIR_STORAGE_TYPE_VOLUME:
/* nothing to do */
break;
}
return true;
}