mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 14:15:28 +00:00
qemu: raise an error when trying to use readonly sata disks
commit 72f919f558
introduced an user
friendly error message when trying to use IDE disks as readonly.
Do the same thing for the SATA bus.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1112939
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
This commit is contained in:
parent
4f3c2e39e5
commit
75d6f42f42
@ -3508,11 +3508,17 @@ qemuBuildDriveStr(virConnectPtr conn,
|
||||
virBufferAddLit(&opt, ",boot=on");
|
||||
if (disk->src->readonly &&
|
||||
virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE_READONLY)) {
|
||||
if (disk->bus == VIR_DOMAIN_DISK_BUS_IDE &&
|
||||
disk->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
|
||||
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||
_("readonly ide disks are not supported"));
|
||||
goto error;
|
||||
if (disk->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
|
||||
if (disk->bus == VIR_DOMAIN_DISK_BUS_IDE) {
|
||||
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||
_("readonly ide disks are not supported"));
|
||||
goto error;
|
||||
}
|
||||
if (disk->bus == VIR_DOMAIN_DISK_BUS_SATA) {
|
||||
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||
_("readonly sata disks are not supported"));
|
||||
goto error;
|
||||
}
|
||||
}
|
||||
virBufferAddLit(&opt, ",readonly=on");
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user