External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-01 20:05:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid crash on OOM in virlockspacetest

Browse Source 
The virlockspacetest.c did not check for failure to create
a lockspace, causing a crash on OOM

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2013-09-25 15:31:48 +01:00
parent 0b30d3458a
commit 7617e5e45d
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/virlockspacetest.c
View File

@ -44,7 +44,8 @@ static int testLockSpaceCreate(const void *args ATTRIBUTE_UNUSED)
rmdir(LOCKSPACE_DIR);
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
if (!(lockspace = virLockSpaceNew(LOCKSPACE_DIR)))
goto cleanup;
if (!virFileIsDir(LOCKSPACE_DIR))
goto cleanup;
@ -65,7 +66,8 @@ static int testLockSpaceResourceLifecycle(const void *args ATTRIBUTE_UNUSED)
rmdir(LOCKSPACE_DIR);
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
if (!(lockspace = virLockSpaceNew(LOCKSPACE_DIR)))
goto cleanup;
if (!virFileIsDir(LOCKSPACE_DIR))
goto cleanup;
@ -98,7 +100,8 @@ static int testLockSpaceResourceLockExcl(const void *args ATTRIBUTE_UNUSED)
rmdir(LOCKSPACE_DIR);
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
if (!(lockspace = virLockSpaceNew(LOCKSPACE_DIR)))
goto cleanup;
if (!virFileIsDir(LOCKSPACE_DIR))
goto cleanup;
@ -143,7 +146,8 @@ static int testLockSpaceResourceLockExclAuto(const void *args ATTRIBUTE_UNUSED)
rmdir(LOCKSPACE_DIR);
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
if (!(lockspace = virLockSpaceNew(LOCKSPACE_DIR)))
goto cleanup;
if (!virFileIsDir(LOCKSPACE_DIR))
goto cleanup;
@ -180,7 +184,8 @@ static int testLockSpaceResourceLockShr(const void *args ATTRIBUTE_UNUSED)
rmdir(LOCKSPACE_DIR);
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
if (!(lockspace = virLockSpaceNew(LOCKSPACE_DIR)))
goto cleanup;
if (!virFileIsDir(LOCKSPACE_DIR))
goto cleanup;
@ -233,7 +238,8 @@ static int testLockSpaceResourceLockShrAuto(const void *args ATTRIBUTE_UNUSED)
rmdir(LOCKSPACE_DIR);
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
if (!(lockspace = virLockSpaceNew(LOCKSPACE_DIR)))
goto cleanup;
if (!virFileIsDir(LOCKSPACE_DIR))
goto cleanup;
@ -292,7 +298,8 @@ static int testLockSpaceResourceLockPath(const void *args ATTRIBUTE_UNUSED)
rmdir(LOCKSPACE_DIR);
lockspace = virLockSpaceNew(NULL);
if (!(lockspace = virLockSpaceNew(NULL)))
goto cleanup;
if (mkdir(LOCKSPACE_DIR, 0700) < 0)
goto cleanup;