From 761f5a52dc6df1bb1f0601770c9761793f6e41f3 Mon Sep 17 00:00:00 2001 From: Mark McLoughlin Date: Sun, 22 Feb 2009 11:19:54 +0000 Subject: [PATCH] networkEnableIpForwarding() now returns zero for success --- ChangeLog | 5 +++++ src/network_driver.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index ff6e08be1b..677c584b62 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Sun Feb 22 11:18:20 GMT 2009 Mark McLoughlin + + * src/network_driver.c: networkEnableIpForwarding() now + returns zero for success + Sun Feb 22 11:06:39 GMT 2009 Mark McLoughlin * docs/formatdomain.html: commit auto-generated change as diff --git a/src/network_driver.c b/src/network_driver.c index b256e3d025..3c765c8ec6 100644 --- a/src/network_driver.c +++ b/src/network_driver.c @@ -794,7 +794,7 @@ networkRemoveIptablesRules(struct network_driver *driver, iptablesSaveRules(driver->iptables); } -/* Enable IP Forwarding. Return 0 for success, nonzero for failure. */ +/* Enable IP Forwarding. Return 0 for success, -1 for failure. */ static int networkEnableIpForwarding(void) { @@ -853,7 +853,7 @@ static int networkStartNetworkDaemon(virConnectPtr conn, goto err_delbr1; if (network->def->forwardType != VIR_NETWORK_FORWARD_NONE && - !networkEnableIpForwarding()) { + networkEnableIpForwarding() < 0) { virReportSystemError(conn, errno, "%s", _("failed to enable IP forwarding")); goto err_delbr2;