External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 21:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: fix inactive snapshot revert

Browse Source 
The commit splitting out the qemuSnapshotRevertInactive function
dropped the 'defined = true' line by accident and instead
returned -1, leaving the user with a cryptic error:
error: An error occurred, but the cause is unknown

https://bugzilla.redhat.com/show_bug.cgi?id=2039136
https://gitlab.com/libvirt/libvirt/-/issues/266

Fixes: 85e4a13c3f
Signed-off-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Ján Tomko 2022-01-20 14:53:33 +01:00
parent 9911a6f2ff
commit 76deb65613
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_snapshot.c
View File

@ -2190,7 +2190,7 @@ qemuSnapshotRevertInactive(virDomainObj *vm,
if (*inactiveConfig) { if (*inactiveConfig) {
virDomainObjAssignDef(vm, inactiveConfig, false, NULL); virDomainObjAssignDef(vm, inactiveConfig, false, NULL);
return -1; defined = true;
} }
if (flags & (VIR_DOMAIN_SNAPSHOT_REVERT_RUNNING | if (flags & (VIR_DOMAIN_SNAPSHOT_REVERT_RUNNING |