External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-25 22:15:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove use of strncpy in qemudExtractMonitorPath.

Browse Source 
qemudExtractMonitorPath() was doing a VIR_ALLOC_N followed by a
strncpy.  However, this isn't necessary; we can do the same thing
using strndup, which is much safer.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
This commit is contained in:
Chris Lalancette 2009-08-03 17:07:19 +02:00
parent bf878aa97e
commit 776f527926
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qemu_driver.c
View File

@ -1029,12 +1029,12 @@ qemudExtractMonitorPath(virConnectPtr conn,
*/ */
while (*tmp) { while (*tmp) {
if (c_isspace(*tmp)) { if (c_isspace(*tmp)) {
if (VIR_ALLOC_N(*path, (tmp-dev)+1) < 0) { *path = strndup(dev, tmp-dev);
if (*path == NULL) {
virReportOOMError(conn); virReportOOMError(conn);
return -1; return -1;
} }
strncpy(*path, dev, (tmp-dev));
(*path)[(tmp-dev)] = '\0';
/* ... now further update offset till we get EOL */ /* ... now further update offset till we get EOL */
*offset = tmp - haystack; *offset = tmp - haystack;
return 0; return 0;