External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 04:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuxml2argvtest: Resolve resource leaks found by Valgrind

Browse Source 
Valgrind deterimined that fakeSecretGetValue() was using the secret
value without checking validity.  Returning NULL causes the caller
to emit a message and results in failure.

Additionally commit 'b090aa7d' changes leaked vncSASLdir and vncTLSx509certdir
This commit is contained in:
John Ferlan 2013-02-04 09:54:33 -05:00
parent 0eb62708a7
commit 785d6bc58a
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/qemuxml2argvtest.c
View File

@ -31,6 +31,9 @@ fakeSecretGetValue(virSecretPtr obj ATTRIBUTE_UNUSED,
unsigned int internalFlags ATTRIBUTE_UNUSED) unsigned int internalFlags ATTRIBUTE_UNUSED)
{ {
char *secret = strdup("AQCVn5hO6HzFAhAAq0NCv8jtJcIcE+HOBlMQ1A"); char *secret = strdup("AQCVn5hO6HzFAhAAq0NCv8jtJcIcE+HOBlMQ1A");
if (!secret) {
return NULL;
}
*value_size = strlen(secret); *value_size = strlen(secret);
return (unsigned char *) secret; return (unsigned char *) secret;
} }
@ -559,7 +562,8 @@ mymain(void)
driver.config->vncTLSx509verify = 1; driver.config->vncTLSx509verify = 1;
DO_TEST("graphics-vnc-tls", QEMU_CAPS_VNC); DO_TEST("graphics-vnc-tls", QEMU_CAPS_VNC);
driver.config->vncSASL = driver.config->vncTLSx509verify = driver.config->vncTLS = 0; driver.config->vncSASL = driver.config->vncTLSx509verify = driver.config->vncTLS = 0;
driver.config->vncSASLdir = driver.config->vncTLSx509certdir = NULL; VIR_FREE(driver.config->vncSASLdir);
VIR_FREE(driver.config->vncTLSx509certdir);
DO_TEST("graphics-sdl", NONE); DO_TEST("graphics-sdl", NONE);
DO_TEST("graphics-sdl-fullscreen", NONE); DO_TEST("graphics-sdl-fullscreen", NONE);