External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-23 03:42:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: free the formatting string when listing pool details

Browse Source 
==23== 41 bytes in 1 blocks are definitely lost in loss record 626 of 727
==23==    by 0x4F0099F: virAsprintfInternal (virstring.c:358)
==23==    by 0x15D2C9: cmdPoolList (virsh-pool.c:1268)

https://bugzilla.redhat.com/show_bug.cgi?id=1001536
This commit is contained in:
Ján Tomko 2013-08-27 13:34:09 +02:00
parent f733eac058
commit 785ff34bf8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/virsh-pool.c
View File

@ -1264,7 +1264,7 @@ cmdPoolList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED)
/* Create the output template. Each column is sized according to /* Create the output template. Each column is sized according to
* the longest string. * the longest string.
*/ */
char *outputStr; char *outputStr = NULL;
ret = virAsprintf(&outputStr, ret = virAsprintf(&outputStr,
"%%-%lus %%-%lus %%-%lus %%-%lus %%%lus %%%lus %%%lus\n", "%%-%lus %%-%lus %%-%lus %%-%lus %%%lus %%%lus %%%lus\n",
(unsigned long) nameStrLength, (unsigned long) nameStrLength,
@ -1319,6 +1319,7 @@ asprintf_failure:
functionReturn = false; functionReturn = false;
cleanup: cleanup:
VIR_FREE(outputStr);
if (list && list->npools) { if (list && list->npools) {
for (i = 0; i < list->npools; i++) { for (i = 0; i < list->npools; i++) {
VIR_FREE(poolInfoTexts[i].state); VIR_FREE(poolInfoTexts[i].state);