External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-11 23:37:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: caps: Don't leak package name string in virQEMUCapsInitQMPMonitor

Browse Source 
If the detected qemu version is below our required version 'package'
would be leaked.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Peter Krempa 2019-03-29 09:32:14 +01:00
parent f7550ecce8
commit 78ad4c559e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/qemu/qemu_capabilities.c
View File

@ -4322,7 +4322,7 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
{ {
int ret = -1; int ret = -1;
int major, minor, micro; int major, minor, micro;
char *package = NULL; VIR_AUTOFREE(char *) package = NULL;
/* @mon is supposed to be locked by callee */ /* @mon is supposed to be locked by callee */
@ -4347,7 +4347,7 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
} }
qemuCaps->version = major * 1000000 + minor * 1000 + micro; qemuCaps->version = major * 1000000 + minor * 1000 + micro;
qemuCaps->package = package; VIR_STEAL_PTR(qemuCaps->package, package);
qemuCaps->usedQMP = true; qemuCaps->usedQMP = true;
if (virQEMUCapsInitQMPArch(qemuCaps, mon) < 0) if (virQEMUCapsInitQMPArch(qemuCaps, mon) < 0)