External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-24 04:12:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

phyp: Resolve Coverity FORWARD_NULL

Browse Source 
Commit id 'cd490086' added a VIR_FORCE_CLOSE of the 'sock', but it
was after the VIR_FREE() of phyp_driver, resulting in a possible/likely
NULL dereference.

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2015-07-01 06:32:34 -04:00
parent c50c664de5
commit 78f1aca076
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/phyp/phyp_driver.c
View File

@ -1249,9 +1249,8 @@ phypConnectClose(virConnectPtr conn)
virObjectUnref(phyp_driver->xmlopt); virObjectUnref(phyp_driver->xmlopt);
phypUUIDTable_Free(phyp_driver->uuid_table); phypUUIDTable_Free(phyp_driver->uuid_table);
VIR_FREE(phyp_driver->managed_system); VIR_FREE(phyp_driver->managed_system);
VIR_FREE(phyp_driver);
VIR_FORCE_CLOSE(phyp_driver->sock); VIR_FORCE_CLOSE(phyp_driver->sock);
VIR_FREE(phyp_driver);
return 0; return 0;
} }