External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-13 00:01:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Reject attempts to create snapshots with names containig '/'

Browse Source 
The snapshot name is used to create path to the definition save file.
When the name contains slashes the creation of the file fails. Reject
such names.
This commit is contained in:
Peter Krempa 2013-01-17 14:07:10 +01:00
parent 27054e1217
commit 790f912b46
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/qemu/qemu_driver.c
View File

@ -11347,6 +11347,16 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain,
parse_flags)))
goto cleanup;
/* reject snapshot names containing slashes as snapshot definitions are
* saved in files containing the name */
if (!(flags & VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA) &&
strchr(def->name, '/')) {
virReportError(VIR_ERR_XML_DETAIL,
_("invalid snapshot name '%s': name can't contain '/'"),
def->name);
goto cleanup;
}
/* reject the VIR_DOMAIN_SNAPSHOT_CREATE_LIVE flag where not supported */
if (flags & VIR_DOMAIN_SNAPSHOT_CREATE_LIVE &&
(!virDomainObjIsActive(vm) ||