External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

udevProcessCCW: Initialize variable

Browse Source 
`udevGetIntSysfsAttr` does not necessarily write to the third parameter,
even when it returns 0.

This was found by clang-tidy's
"clang-analyzer-core.UndefinedBinaryOperatorResult" check.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Tim Wiederhake 2021-02-01 13:42:03 +01:00 committed by Peter Krempa
parent 1e2e8ac88f
commit 795187fe0c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/node_device/node_device_udev.c
View File

@ -1100,7 +1100,7 @@ static int
udevProcessCCW(struct udev_device *device, udevProcessCCW(struct udev_device *device,
virNodeDeviceDefPtr def) virNodeDeviceDefPtr def)
{ {
int online; int online = 0;
/* process only online devices to keep the list sane */ /* process only online devices to keep the list sane */
if (udevGetIntSysfsAttr(device, "online", &online, 0) < 0 || online != 1) if (udevGetIntSysfsAttr(device, "online", &online, 0) < 0 || online != 1)