External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Code

conf: Remove ATTRIBUTE_FALLTHROUGH from virDomainChrTargetDefFormat()

Browse Source 
Formatting the <target/> element for serial devices will become a
bit more complicated later on, and leaving the fallthrough behavior
there would do nothing but complicate it further.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Andrea Bolognani 2017-11-21 13:03:19 +01:00
parent 46084f2aa1
commit 7983068fa5
1 changed files with 9 additions and 5 deletions

14
src/conf/domain_conf.c

@ -24019,14 +24019,18 @@ virDomainChrTargetDefFormat(virBufferPtr buf,
return -1; return -1;
} }
virBufferAddLit(buf, "<target ");
if (def->targetType != VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE) { if (def->targetType != VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE) {
virBufferAsprintf(buf, virBufferAsprintf(buf,
"<target type='%s' port='%d'/>\n", "type='%s' ",
targetType, targetType);
def->target.port);
break;
} }
ATTRIBUTE_FALLTHROUGH;
virBufferAsprintf(buf,
"port='%d'/>\n",
def->target.port);
break;
case VIR_DOMAIN_CHR_DEVICE_TYPE_PARALLEL: case VIR_DOMAIN_CHR_DEVICE_TYPE_PARALLEL:
virBufferAsprintf(buf, "<target port='%d'/>\n", virBufferAsprintf(buf, "<target port='%d'/>\n",