From 79b04c9606f5f61358b506311d1d16b4c1a622e3 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Mon, 22 May 2023 12:49:17 +0200 Subject: [PATCH] testQEMUSchemaValidateObjectMember: validate QMP object member deprecation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The QMP schema validator wasn't adapted to consider features of 'object' members and thus we didn't catch the deprecation of 'device' in 'block_set_io_throttle'. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- tests/testutilsqemuschema.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/testutilsqemuschema.c b/tests/testutilsqemuschema.c index d431e7b3fc..f7b2e122bd 100644 --- a/tests/testutilsqemuschema.c +++ b/tests/testutilsqemuschema.c @@ -187,6 +187,10 @@ testQEMUSchemaValidateObjectMember(const char *key, return -1; } + /* validate that the member is not deprecated */ + if ((rc = testQEMUSchemaValidateDeprecated(keymember, key, data->ctxt)) < 0) + return rc; + /* lookup schema entry for keytype */ if (!(keytype = virJSONValueObjectGetString(keymember, "type")) || !(keyschema = virHashLookup(data->ctxt->schema, keytype))) {