External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

virbitmaptest: Use separate output strings in 'test5'

Browse Source 
The test validates two outputs. Don't reuse 'str' for both.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2020-10-05 11:28:14 +02:00
parent 5e309e82a7
commit 7a1bc02be9
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/virbitmaptest.c
View File

@ -329,7 +329,8 @@ test5(const void *v G_GNUC_UNUSED)
size_t i;
ssize_t j;
int ret = -1;
char *str = NULL;
g_autofree char *actual1 = NULL;
g_autofree char *actual2 = NULL;
bitmap = virBitmapNewData(data, sizeof(data));
if (!bitmap)
@ -359,19 +360,17 @@ test5(const void *v G_GNUC_UNUSED)
data2[4] != 0x04)
goto error;
if (!(str = virBitmapDataFormat(data, sizeof(data))))
if (!(actual1 = virBitmapDataFormat(data, sizeof(data))))
goto error;
if (STRNEQ(str, "0,9,34"))
if (STRNEQ(actual1, "0,9,34"))
goto error;
VIR_FREE(str);
if (!(str = virBitmapDataFormat(data2, len2)))
if (!(actual2 = virBitmapDataFormat(data2, len2)))
goto error;
if (STRNEQ(str, "0,2,9,15,34"))
if (STRNEQ(actual2, "0,2,9,15,34"))
goto error;
ret = 0;
error:
VIR_FREE(str);
virBitmapFree(bitmap);
VIR_FREE(data2);
return ret;