mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-29 20:11:16 +00:00
qemu_process.c: remove 'cleanup' label from qemuProcessCreatePretendCmd()
The 'cleanup' flag is doing no cleaup in this function. We can remove it and return NULL on error or qemuBuildCommandLine(). Reviewed-by: Cole Robinson <crobinso@redhat.com> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
This commit is contained in:
parent
d8eb3ab9e1
commit
7a7d36055c
@ -7148,11 +7148,9 @@ qemuProcessCreatePretendCmd(virQEMUDriverPtr driver,
|
||||
bool standalone,
|
||||
unsigned int flags)
|
||||
{
|
||||
virCommandPtr cmd = NULL;
|
||||
|
||||
virCheckFlagsGoto(VIR_QEMU_PROCESS_START_COLD |
|
||||
virCheckFlags(VIR_QEMU_PROCESS_START_COLD |
|
||||
VIR_QEMU_PROCESS_START_PAUSED |
|
||||
VIR_QEMU_PROCESS_START_AUTODESTROY, cleanup);
|
||||
VIR_QEMU_PROCESS_START_AUTODESTROY, NULL);
|
||||
|
||||
flags |= VIR_QEMU_PROCESS_START_PRETEND;
|
||||
flags |= VIR_QEMU_PROCESS_START_NEW;
|
||||
@ -7161,13 +7159,13 @@ qemuProcessCreatePretendCmd(virQEMUDriverPtr driver,
|
||||
|
||||
if (qemuProcessInit(driver, vm, NULL, QEMU_ASYNC_JOB_NONE,
|
||||
!!migrateURI, flags) < 0)
|
||||
goto cleanup;
|
||||
return NULL;
|
||||
|
||||
if (qemuProcessPrepareDomain(driver, vm, flags) < 0)
|
||||
goto cleanup;
|
||||
return NULL;
|
||||
|
||||
VIR_DEBUG("Building emulator command line");
|
||||
cmd = qemuBuildCommandLine(driver,
|
||||
return qemuBuildCommandLine(driver,
|
||||
NULL,
|
||||
driver->securityManager,
|
||||
vm,
|
||||
@ -7178,9 +7176,6 @@ qemuProcessCreatePretendCmd(virQEMUDriverPtr driver,
|
||||
enableFips,
|
||||
NULL,
|
||||
NULL);
|
||||
|
||||
cleanup:
|
||||
return cmd;
|
||||
}
|
||||
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user