External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-30 01:43:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

bridge_driver: Don't check network active unlocked

Browse Source 
Okay, this is mainly for educational purposes since is called
from single point only with all the possible locks held. So
there's no way for other thread to hop in and do something wrong.
Nevertheless, we should not give bad example.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2015-02-23 19:00:57 +01:00
parent bf1afdd491
commit 7b8c12d8ce
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/network/bridge_driver.c
View File

@ -353,10 +353,11 @@ networkUpdateAllState(void)
for (i = 0; i < driver->networks.count; i++) {
virNetworkObjPtr obj = driver->networks.objs[i];
if (!obj->active)
continue;
virNetworkObjLock(obj);
if (!virNetworkObjIsActive(obj)) {
virNetworkObjUnlock(obj);
continue;
}
switch (obj->def->forward.type) {
case VIR_NETWORK_FORWARD_NONE: