External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-25 04:42:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

xenXMDomainDefineXML: remove dead store and useless/leaky virGetDomain

Browse Source 
* src/xen/xm_internal.c (xenXMDomainDefineXML): Remove useless and
leak-inducing call to virGetDomain, as well as decl of now-unused local.
This commit is contained in:
Jim Meyering 2010-04-07 20:17:44 +02:00
parent 2cdf29eda9
commit 7be5c26d74
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/xen/xm_internal.c
View File

@ -2622,7 +2622,6 @@ cleanup:
*/ */
virDomainPtr xenXMDomainDefineXML(virConnectPtr conn, const char *xml) { virDomainPtr xenXMDomainDefineXML(virConnectPtr conn, const char *xml) {
virDomainPtr ret; virDomainPtr ret;
virDomainPtr olddomain;
char filename[PATH_MAX]; char filename[PATH_MAX];
const char * oldfilename; const char * oldfilename;
virDomainDefPtr def = NULL; virDomainDefPtr def = NULL;
@ -2688,10 +2687,6 @@ virDomainPtr xenXMDomainDefineXML(virConnectPtr conn, const char *xml) {
goto error; goto error;
} }
/* XXX wtf.com is this line for - it appears to be amemory leak */
if (!(olddomain = virGetDomain(conn, def->name, entry->def->uuid)))
goto error;
/* Remove the name -> filename mapping */ /* Remove the name -> filename mapping */
if (virHashRemoveEntry(priv->nameConfigMap, def->name, NULL) < 0) { if (virHashRemoveEntry(priv->nameConfigMap, def->name, NULL) < 0) {
xenXMError(VIR_ERR_INTERNAL_ERROR, xenXMError(VIR_ERR_INTERNAL_ERROR,