External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_driver: Introduce testDomainObjCheckTaint

Browse Source 
In order to test the virDomainGetMessages for test driver, we need to
check some taints or deprecations, so introduce testDomainObjCheckTaint
for checking taints.

As we introduced testDomainObjCheckTaint for test driver, the `dominfo`
command in virshtest will now print tainting messages, so add them for
test.

Signed-off-by: Luke Yue <lukedyue@gmail.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Luke Yue 2021-07-12 19:32:16 +08:00 committed by Martin Kletzander
parent 68095b835f
commit 7c399a9b0e
2 changed files with 79 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

77
src/test/test_driver.c
View File

@ -746,6 +746,81 @@ static char *testBuildFilename(const char *relativeTo,
return g_strdup_printf("%s/%s", basename, filename);
}
static void
testDomainObjCheckCPUTaint(virDomainObj *obj)
{
switch (obj->def->cpu->mode) {
case VIR_CPU_MODE_CUSTOM:
if (obj->def->cpu->model)
if (STREQ(obj->def->cpu->model, "Deprecated-Test")) {
virDomainObjTaint(obj, VIR_DOMAIN_TAINT_DEPRECATED_CONFIG);
virDomainObjDeprecation(obj, "CPU model Deprecated-Test");
}
break;
default:
break;
}
}
static void
testDomainObjCheckDiskTaint(virDomainObj *obj,
virDomainDiskDef *disk)
{
if (disk->rawio == VIR_TRISTATE_BOOL_YES)
virDomainObjTaint(obj, VIR_DOMAIN_TAINT_HIGH_PRIVILEGES);
if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM &&
virStorageSourceGetActualType(disk->src) == VIR_STORAGE_TYPE_BLOCK &&
disk->src->path)
virDomainObjTaint(obj, VIR_DOMAIN_TAINT_CDROM_PASSTHROUGH);
}
static void
testDomainObjCheckHostdevTaint(virDomainObj *obj,
virDomainHostdevDef *hostdev)
{
if (!virHostdevIsSCSIDevice(hostdev))
return;
if (hostdev->source.subsys.u.scsi.rawio == VIR_TRISTATE_BOOL_YES)
virDomainObjTaint(obj, VIR_DOMAIN_TAINT_HIGH_PRIVILEGES);
}
static void
testDomainObjCheckNetTaint(virDomainObj *obj,
virDomainNetDef *net)
{
/* script is only useful for NET_TYPE_ETHERNET (qemu) and
* NET_TYPE_BRIDGE (xen), but could be (incorrectly) specified for
* any interface type. In any case, it's adding user sauce into
* the soup, so it should taint the domain.
*/
if (net->script != NULL)
virDomainObjTaint(obj, VIR_DOMAIN_TAINT_SHELL_SCRIPTS);
}
static void
testDomainObjCheckTaint(virDomainObj *obj)
{
size_t i;
for (i = 0; i < obj->def->ndisks; i++)
testDomainObjCheckDiskTaint(obj, obj->def->disks[i]);
for (i = 0; i < obj->def->nhostdevs; i++)
testDomainObjCheckHostdevTaint(obj, obj->def->hostdevs[i]);
for (i = 0; i < obj->def->nnets; i++)
testDomainObjCheckNetTaint(obj, obj->def->nets[i]);
if (obj->def->cpu)
testDomainObjCheckCPUTaint(obj);
if (obj->def->os.dtb)
virDomainObjTaint(obj, VIR_DOMAIN_TAINT_CUSTOM_DTB);
}
static xmlNodePtr
testParseXMLDocFromFile(xmlNodePtr node, const char *file, const char *type)
{
@ -968,6 +1043,8 @@ testParseDomains(testDriver *privconn,
}
virDomainObjSetState(obj, nsdata->runstate, 0);
testDomainObjCheckTaint(obj);
virDomainObjEndAPI(&obj);
}

2
tests/virshtest.c
View File

@ -22,6 +22,7 @@ main(void)
# define DOM_UUID "ef861801-45b9-11cb-88e3-afbfe5370493"
# define SECURITY_LABEL "libvirt-test (enforcing)"
# define MESSAGES "tainted: network configuration using opaque shell scripts"
static const char *dominfo_fc4 = "\
Id: 2\n\
@ -38,6 +39,7 @@ Managed save: no\n\
Security model: testSecurity\n\
Security DOI: \n\
Security label: " SECURITY_LABEL "\n\
Messages: " MESSAGES "\n\
\n";
static const char *domuuid_fc4 = DOM_UUID "\n\n";
static const char *domid_fc4 = "2\n\n";