External/libvirt
1
0
Fork 0
Code

qemuProcessSetupDisksTransientSnapshot: Skip enabling transientOverlayCreated flag

Browse Source 
QEMU_DOMAIN_DISK_PRIVATE(disk)->transientOverlayCreated flag
gets true unexpectedly on qemuProcessSetupDisksTransientSnapshot() when
the disk has <transient shareBacking='yes'> option.

The flag should be enabled on qemuDomainAttachDiskGeneric() after the
overlay setup is completed.

Skip enabling transientOverlayCreated for the disk here.

Fixes: 75871da0ecb8b552f9e304d0f83e216839bbf82d
Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Masayoshi Mizuma 2021-05-27 12:55:12 -04:00 committed by Peter Krempa
parent 70f53b1c04
commit 7c69f72230
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/qemu/qemu_process.c
View File

@ -7039,7 +7039,8 @@ qemuProcessSetupDisksTransientSnapshot(virDomainObj *vm,
for (i = 0; i < vm->def->ndisks; i++) { for (i = 0; i < vm->def->ndisks; i++) {
virDomainDiskDef *domdisk = vm->def->disks[i]; virDomainDiskDef *domdisk = vm->def->disks[i];
if (!domdisk->transient) if (!domdisk->transient ||
domdisk->transientShareBacking == VIR_TRISTATE_BOOL_YES)
continue; continue;
QEMU_DOMAIN_DISK_PRIVATE(domdisk)->transientOverlayCreated = true; QEMU_DOMAIN_DISK_PRIVATE(domdisk)->transientOverlayCreated = true;