From 7c849ad51898f4d94f33577eb0bf60beb11bf290 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 2 Aug 2022 13:54:35 +0200 Subject: [PATCH] qemuMonitorTestNew: Call qemuMonitorOpen with 'retry' false The 'retry' argument makes the monitor connection opening re-try the connection in case the monitor socket doesn't exist or isn't properly listening. In case of the test code this can't happen because the socket is created and made listening in 'qemuMonitorCommonTestNew' which is called prior to calling 'qemuMonitorOpen'. We can thus avoit the code which attempts retries in monitor connection. Signed-off-by: Peter Krempa Reviewed-by: Jonathon Jongsma --- tests/qemumonitortestutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index 50808f1fb5..1ea8d72711 100644 --- a/tests/qemumonitortestutils.c +++ b/tests/qemumonitortestutils.c @@ -1109,7 +1109,7 @@ qemuMonitorTestNew(virDomainXMLOption *xmlopt, test->qapischema = schema; if (!(test->mon = qemuMonitorOpen(test->vm, &src, - true, + false, virEventThreadGetContext(test->eventThread), &qemuMonitorTestCallbacks))) goto error;