mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-21 20:15:17 +00:00
maint: avoid spurious output if program not present
Some shells warn about missing programs before redirection; the idiomatic way to silence them is to run the program check inside a subshell, with the redirections outside the subshell. But a subshell is only needed in places where it is reasonable to expect the use of such a noisy shell in the first place. * src/Makefile.am (remote_protocol-structs): Use subshell, for FreeBSD 8.0 /bin/sh. * cfg.mk (sc_preprocessor_indentation): Avoid subshell, since the only users running cfg.mk can be assumed to have decent tools.
This commit is contained in:
parent
23958aedf4
commit
7cdf26637e
2
cfg.mk
2
cfg.mk
@ -252,7 +252,7 @@ sc_prohibit_trailing_blank_lines:
|
||||
preprocessor_exempt = (remote_(driver|protocol)\.h)$$
|
||||
# Enforce recommended preprocessor indentation style.
|
||||
sc_preprocessor_indentation:
|
||||
@if (cppi --version >/dev/null 2>&1); then \
|
||||
@if cppi --version >/dev/null 2>&1; then \
|
||||
$(VC_LIST_EXCEPT) | grep '\.[ch]$$' \
|
||||
| grep -vE '$(preprocessor_exempt)' | xargs cppi -a -c \
|
||||
|| { echo '$(ME): incorrect preprocessor indentation' 1>&2; \
|
||||
|
@ -169,7 +169,7 @@ EXTRA_DIST += remote/remote_protocol.x remote/rpcgen_fix.pl
|
||||
# * remove white space at end of buffer
|
||||
.PHONY: remote_protocol-structs
|
||||
remote_protocol-structs:
|
||||
$(AM_V_GEN)if pdwtags --help > /dev/null 2>&1; then \
|
||||
$(AM_V_GEN)if (pdwtags --help) > /dev/null 2>&1; then \
|
||||
pdwtags libvirt_driver_remote_la-remote_protocol.$(OBJEXT) \
|
||||
| perl -0777 -n \
|
||||
-e 'foreach my $$p (split m!\n\n/\* \d+ \*/\n!)' \
|
||||
|
Loading…
x
Reference in New Issue
Block a user