From 7e2086257602a4726e7affd2806f4f984ea6287d Mon Sep 17 00:00:00 2001 From: ZhiPeng Lu Date: Wed, 27 Sep 2017 16:53:50 +0800 Subject: [PATCH] nwfilter: Fix memory leak in virNWFilterIPAddrMapAddIPAddr If virNWFilterHashTablePut fails, then the @val was leaked. Signed-off-by: ZhiPeng Lu --- src/conf/nwfilter_ipaddrmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/nwfilter_ipaddrmap.c b/src/conf/nwfilter_ipaddrmap.c index 446f3de4f9..9c8584ce27 100644 --- a/src/conf/nwfilter_ipaddrmap.c +++ b/src/conf/nwfilter_ipaddrmap.c @@ -61,6 +61,8 @@ virNWFilterIPAddrMapAddIPAddr(const char *ifname, char *addr) if (!val) goto cleanup; ret = virNWFilterHashTablePut(ipAddressMap, ifname, val); + if (ret < 0) + virNWFilterVarValueFree(val); goto cleanup; } else { if (virNWFilterVarValueAddValue(val, addr) < 0)