External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Code

virDomainChrSourceDefCopy: Don't check arguments against NULL

Browse Source 
The only caller of this function
(qemuProcessFindCharDevicePTYsMonitor()) doesn't pass NULL.
Remove corresponding check from virDomainChrSourceDefCopy().

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Michal Privoznik 2022-01-24 08:55:52 +01:00
parent 8af76c3764
commit 7e57285eec
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/conf/domain_conf.c
View File

@ -2739,9 +2739,6 @@ int
virDomainChrSourceDefCopy(virDomainChrSourceDef *dest,
virDomainChrSourceDef *src)
{
if (!dest || !src)
return -1;
virDomainChrSourceDefClear(dest);
dest->type = src->type;

3
src/conf/domain_conf.h
View File

@ -3349,7 +3349,8 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainSmartcardDef, virDomainSmartcardDefFree);
void virDomainChrDefFree(virDomainChrDef *def);
G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainChrDef, virDomainChrDefFree);
int virDomainChrSourceDefCopy(virDomainChrSourceDef *dest,
virDomainChrSourceDef *src);
virDomainChrSourceDef *src)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
void virDomainSoundCodecDefFree(virDomainSoundCodecDef *def);
ssize_t virDomainSoundDefFind(const virDomainDef *def,
const virDomainSoundDef *sound);