External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: storage: Use strict version of virStorageFileGetMetadata

Browse Source 
Pass in 'true' as '@report_broken' of virStorageFileGetMetadata to make
it fail in the tests. The most important code paths (when starting the
VM) expect this function to fail rather than silently return partial
data. Switch the test to exercise this more important code path.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2019-12-17 17:46:18 +01:00
parent 6c17606b7c
commit 7e582fe995
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/virstoragetest.c
View File

@ -103,7 +103,7 @@ testStorageFileGetMetadata(const char *path,
def->path = g_strdup(path); def->path = g_strdup(path);
if (virStorageFileGetMetadata(def, uid, gid, false) < 0) if (virStorageFileGetMetadata(def, uid, gid, true) < 0)
return NULL; return NULL;
return g_steal_pointer(&def); return g_steal_pointer(&def);
@ -775,7 +775,7 @@ mymain(void)
qcow2.expBackingStoreRaw = datadir "/bogus"; qcow2.expBackingStoreRaw = datadir "/bogus";
/* Qcow2 file with missing backing file but specified type */ /* Qcow2 file with missing backing file but specified type */
TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2), EXP_WARN); TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2), EXP_FAIL);
/* Rewrite qcow2 to a missing backing file, without backing type */ /* Rewrite qcow2 to a missing backing file, without backing type */
virCommandFree(cmd); virCommandFree(cmd);
@ -785,7 +785,7 @@ mymain(void)
ret = -1; ret = -1;
/* Qcow2 file with missing backing file and no specified type */ /* Qcow2 file with missing backing file and no specified type */
TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2), EXP_WARN); TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2), EXP_FAIL);
/* Rewrite qcow2 to use an nbd: protocol as backend */ /* Rewrite qcow2 to use an nbd: protocol as backend */
virCommandFree(cmd); virCommandFree(cmd);
@ -916,7 +916,7 @@ mymain(void)
qcow2.expBackingStoreRaw = "qcow2"; qcow2.expBackingStoreRaw = "qcow2";
/* Behavior of an infinite loop chain */ /* Behavior of an infinite loop chain */
TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2), EXP_WARN); TEST_CHAIN(absqcow2, VIR_STORAGE_FILE_QCOW2, (&qcow2), EXP_FAIL);
/* Rewrite wrap and qcow2 to be mutually-referential loop */ /* Rewrite wrap and qcow2 to be mutually-referential loop */
virCommandFree(cmd); virCommandFree(cmd);
@ -933,7 +933,7 @@ mymain(void)
qcow2.expBackingStoreRaw = "wrap"; qcow2.expBackingStoreRaw = "wrap";
/* Behavior of an infinite loop chain */ /* Behavior of an infinite loop chain */
TEST_CHAIN(abswrap, VIR_STORAGE_FILE_QCOW2, (&wrap, &qcow2), EXP_WARN); TEST_CHAIN(abswrap, VIR_STORAGE_FILE_QCOW2, (&wrap, &qcow2), EXP_FAIL);
/* Rewrite qcow2 to use an rbd: protocol as backend */ /* Rewrite qcow2 to use an rbd: protocol as backend */
virCommandFree(cmd); virCommandFree(cmd);